Skip to content

[17.0][MIG] pos_payment_change#1331

Open
em230418 wants to merge 43 commits intoOCA:17.0from
em230418:17.0-mig-pos_payment_change
Open

[17.0][MIG] pos_payment_change#1331
em230418 wants to merge 43 commits intoOCA:17.0from
em230418:17.0-mig-pos_payment_change

Conversation

@em230418
Copy link
Copy Markdown
Contributor

@em230418 em230418 commented Mar 13, 2025

No description provided.

@em230418
Copy link
Copy Markdown
Contributor Author

em230418 commented Mar 13, 2025

I am aware of #1264

@em230418 em230418 force-pushed the 17.0-mig-pos_payment_change branch 2 times, most recently from a3c9f37 to 323a301 Compare March 14, 2025 04:50
em230418
em230418 commented Mar 14, 2025
View reviewed changes
Comment thread pos_payment_change/tests/test_module.py Outdated
em230418
em230418 commented Mar 17, 2025
View reviewed changes
Comment thread pos_payment_change/models/pos_order.py Outdated
@em230418 em230418 marked this pull request as ready for review May 17, 2025 12:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 21, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 21, 2025
@em230418 em230418 force-pushed the 17.0-mig-pos_payment_change branch from a95c9c2 to c55607c Compare September 28, 2025 04:21
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 28, 2025
@Abranes Abranes mentioned this pull request Nov 9, 2025
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 1, 2026
@em230418
Copy link
Copy Markdown
Contributor Author

em230418 commented Feb 16, 2026

so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.

Please no

@cvinh
Copy link
Copy Markdown
Contributor

cvinh commented Feb 16, 2026

@em230418 maybe you can rebase to unlock runboat. Then your PR can be tested by reviewers

@etobella
Copy link
Copy Markdown
Member

etobella commented Feb 16, 2026

/ocabot rebase

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 16, 2026

Congratulations, PR rebased to 17.0.

@OCA-git-bot OCA-git-bot force-pushed the 17.0-mig-pos_payment_change branch from c55607c to f0e61de Compare February 16, 2026 18:12
cvinh
cvinh suggested changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat LGTM
There's a small issue (it's not because of the migration) when you select a refunded order in the frontend : the 3 orders get selected at once and the original one opens.
Then we want an invoice, the invoice is linked to the original one.
Maybe you can add this in the roadmap part of the readme

@ilmir-k
Copy link
Copy Markdown

ilmir-k commented Feb 17, 2026

LGTM

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 22, 2026
ivantodorovich
ivantodorovich approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration pos_payment_change
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 9, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 9, 2026

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1331-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 9, 2026
@OCA-git-bot
Merge PR #1331 into 17.0
058f5a2 
Signed-off-by ivantodorovich
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 9, 2026
Open
35 tasks
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 9, 2026

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1331-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 9, 2026
@OCA-git-bot
Merge PR #1331 into 17.0
ee5936e 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 9, 2026

@ivantodorovich The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name pos --branch 17.0 --addons-dir /tmp/tmpoqdmvk4c --commit failed with output:

/tmp/tmpoqdmvk4c/pos_payment_change/README.rst:96: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 6, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1485, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1406, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1269, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 824, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 465, in publish_file
    output, _publisher = publish_programmatically(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 794, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 269, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 95, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 101, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 185, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 182, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 234, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 446, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2487, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2499, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2215, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 2063, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 256, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 217, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpoqdmvk4c/pos_payment_change/README.rst:96: (ERROR/3) Duplicate substitution definition name: "image1".

julenfl and others added 26 commits April 21, 2026 08:48
@julenfl @em230418
[FIX] the method _check_pos_session_balance is deleted in point_of_sale
74e1c51
@em230418
[FIX] use float_compare to compare floats
be6a3bd
@julenfl @em230418
[MIG] pos_payment_change: modification wizard view, add widget selection
6dd8c73
@em230418
[UPD] Update pos_payment_change.pot
4fe4304
@OCA-git-bot @em230418
[UPD] README.rst
11e3d01
@lbpatri @em230418
Translated using Weblate (Spanish)
a8a89e8 
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/
@mymage @em230418
Added translation using Weblate (Italian)
7f27e72
@mymage @em230418
Translated using Weblate (Italian)
951fb14 
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/
@OCA-git-bot @em230418
[UPD] README.rst
d08da9f
@weblate @em230418
Update translation files
30c4c1c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/
@Ivorra78 @em230418
Translated using Weblate (Spanish)
c7aebbc 
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/
@em230418
Translated using Weblate (French)
08022da 
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/
@legalsylvain @em230418
[FIX] pos_payment_change : check installation fo existing modules.
7768bbf 
In old version, two certifications modules was present in odoo.  l10n_fr_pos_cert and l10n_fr_certification.
In odoo 16, only l10n_fr_pos_cert exists.
@OCA-git-bot @em230418
[BOT] post-merge updates
e195ea7
@nayatec @em230418
[FIX] use right method to access action in change payment - remove th…
b38fc65 
…e obsolete Warning
@nayatec @em230418
more concise test
be96a30
@OCA-git-bot @em230418
[BOT] post-merge updates
30c7677
@flotho @em230418
[DOC]Appropriate readm for v16
eb4622d 
Better readme
FIX OCA#1115
@OCA-git-bot @em230418
[BOT] post-merge updates
671f7ae
@alexis-via @em230418
[FIX] pos_payment_change: ondelete='cascade' for O2M fields
a866d1c
@OCA-git-bot @em230418
[BOT] post-merge updates
f1ae142
@em230418
[IMP] pos_payment_change: pre-commit auto fixes
a5b613a
@em230418
[MIG] pos_payment_change: Migration to 17.0
6318ca8
@em230418
[FIX] pos_payment_change: rebase test on TestPoSCommon
cfc8bdc
@em230418
[FIX] pos_payment_change: in tests replace Marc Demo to user with exp…
b9bfac6 
…licit rights
@em230418
[FIX] pos_payment_change: add compatibility with pos_order_copy
4410635
@em230418 em230418 force-pushed the 17.0-mig-pos_payment_change branch from 593cff8 to 4410635 Compare April 21, 2026 03:48
@em230418
Copy link
Copy Markdown
Contributor Author

em230418 commented Apr 21, 2026

rebased to upstream 17.0 in hope it will fix this

@OCA-git-bot OCA-git-bot added mod:pos_payment_change Module pos_payment_change series:17.0 labels Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella left review comments

@ivantodorovich ivantodorovich ivantodorovich approved these changes

+1 more reviewer

@cvinh cvinh cvinh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:pos_payment_change Module pos_payment_change series:17.0

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.